[useMediaQuery] Fix behavior of noSsr with React 18 #36056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36054. The solution is to run
matchMedia
on the client side side when React callsgetServerSnapshot
. The docs says:https://beta.reactjs.org/reference/react/useSyncExternalStore
In our case, when a developer set
noSsr: true
he explicitly opt-out from trying to hydrate with the first server-side render, while he also server-side render. The concern of tearing in #30655 should be OK since this change only impacts the server snapshot, React will update if needed when callinggetSnapshot
.